Skip to content

Conversation

@benjamaan476
Copy link
Contributor

Extend the Chamfer API to allow the addition of new arguments to the chamfer call, e.g. the angle of the chamfer cut

@benjamaan476 benjamaan476 self-assigned this Sep 8, 2025
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@caecee0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/shared.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage        ?   26.15%           
=======================================
  Files           ?       35           
  Lines           ?     1717           
  Branches        ?        0           
=======================================
  Hits            ?      449           
  Misses          ?     1268           
  Partials        ?        0           
Flag Coverage Δ
unittests 26.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjamaan476 benjamaan476 requested a review from jtran September 22, 2025 17:13
@benjamaan476 benjamaan476 marked this pull request as ready for review September 22, 2025 17:14
@benjamaan476 benjamaan476 merged commit aa231cc into main Sep 23, 2025
13 checks passed
@benjamaan476 benjamaan476 deleted the ben/chamfer_angle branch September 23, 2025 15:40
jtran added a commit that referenced this pull request Sep 23, 2025
jtran added a commit that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants