Improve permissions in Docker image#1286
Merged
Merged
Conversation
Copy files and execute commands as www-data as much as possible, rather than using chown, chgrp, or chmod after the fact. This makes it so we no longer have to explicitly configure the CDash clone as a safe directory for git.
Contributor
Author
|
as a secondary benefit, this PR seems to shave 8 minutes off our CI time |
josephsnyder
approved these changes
Jan 27, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Builds nice and quick. Not waiting for that big chown command really does save a chunk of time. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy files and execute commands as www-data as much as possible, rather than using chown, chgrp, or chmod after the fact.
This makes it so we no longer have to explicitly configure the CDash clone as a safe directory for git.