Don't run PHP style fixer before running test suite#1316
Merged
williamjallen merged 2 commits intoMar 5, 2023
Conversation
zackgalbreath
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently run the PHP style fixer during the CMake configure step, which fixes most of the code before we re-run the fixer again during the testing process to catch style issues. This means that there are potentially style issues in the codebase which are not caught by our test suite because they are automatically fixed before the test suite is run.
This PR removes the "fix" step from the CMake configure process. To automatically fix changes locally, it is now necessary to run
vendor/bin/php-cs-fixer fixmanually.In the future, we may want to investigate using PHP_CodeSniffer instead of PHP-CS-Fixer since the former provides more helpful errors.
I believe that this fixes #1309.