Separate API endpoints into individual namespaces#1325
Merged
Conversation
Also: general code quality improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1314 did not properly handle multiple functions with the same name in the global namespace. Depending on the order in which PHPStan analyzed files, a greater or lesser number of errors could be generated, which caused the CI to be flaky.
This PR separates each of the API endpoints into individual namespaces such that function names such as
rest_postno longer pollute the global namespace, and do not cause PHPStan to return faulty results.Alongside the required changes, I have also made a number of smaller changes along the way, including dead code removal and typing cleanups.