Use Laravel routing instead of public-facing PHP files#1340
Merged
Conversation
williamjallen
force-pushed
the
deprecate-old-routes
branch
3 times, most recently
from
07d6982 to
62c1628
Compare
williamjallen
force-pushed
the
deprecate-old-routes
branch
from
62c1628 to
2e5ef27
Compare
josephsnyder
approved these changes
Apr 4, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Great work! I can't find functionality differences or broken links on the local instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most AngularJS-based pages and their corresponding API endpoints are individual publicly-accessible PHP files. As our migration to Laravel progresses, it will be useful to have all of our routing done through Laravel. This PR moves several AngularJS-based pages and their corresponding endpoints to a Laravel controller, with Laravel routing. These changes serve as the first step towards a total migration to Laravel routing. I plan to make a sequence of similar PRs to migrate these pages in small batches.
All of the previous routes have been kept and no new routes have been added. In the future, it would be good to overhaul our routing scheme, but that may have to wait until the next major version of CDash.