Closed
Conversation
Merged
Collaborator
Author
|
Superseded by #1827. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
I made a mistake when creating #1374 by attempting to lint all of the files while adding eslint. This iteration of my eslint work moves the eslint step from our Mix build to a test which runs in our CI. I also cleaned up the mix file at the same time, because it contained a bunch of confusing JS code. Once this PR is merged, I plan to lint sections of the codebase in batches to slowly enable eslint. For now, most files are ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have an eslint configuration, but eslint is not run as part of our regular test suite. This PR adds an eslint task to the test suite, and fixes the outstanding failures. Our current eslint configuration is fairly primitive and more rules should be added in the future.