Simplify logging#1383
Merged
Merged
Conversation
williamjallen
force-pushed
the
logging-refactor
branch
from
fe3adbb to
6af4141
Compare
williamjallen
force-pushed
the
logging-refactor
branch
from
6af4141 to
c97722e
Compare
josephsnyder
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel's built-in logging functionality is the preferred method to use for logging. We also have pre-Laravel logging infrastructure which was deprecated in #1342. This PR eliminates some of the deprecated code, leaving only the
add_log()function as the last bit of non-Laravel logging code.add_log()has 200+ usages currently, so it will likely be some time before we are able to fully phase it out.