Add support for SAML2 authentication#1386
Merged
Merged
Conversation
josephsnyder
approved these changes
Apr 26, 2023
Member
There was a problem hiding this comment.
Everything looks solid. The Docker-compose system has no problem with the new artisan packages, but I can't quite test the saml2_tenant creation.
The only non-blocking nitpick would be that some of the functions still put the return type in the doc comment instead of in the function definition while others do not:
saml2LogininLoginController.phpcreateinRegisterController.phpshouldDiscoverEventsinEventServiceProvider.php
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Overall, code looks decent. A few minor nitpicks noted below and then I think it should be ready to go.
williamjallen
approved these changes
May 10, 2023
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Changes seem reasonable, assuming tests pass
This commit also replaces the table layout with a bootstrap grid on login.blade.php. This was necessary because you can only have one form per table. As part of this commit we now install the following composer packages: * phpstan/phpstan-mockery * phpstan/extension-installer phpstan-mockery prevents PHPStan from complaining about our use of mocks in tests. extension-installer makes it so we no longer have to explicitly list our PHPStan extensions in phpstan.neon.
This also contains a very rudimentary table of contents for CDash's markdown documentation. I expect this to be improved, expanded, and better organized in the not-too-distant future, but at the moment having links to our existing docs is a step in the right direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.