Remove dead code from Subscription.php#1392
Merged
williamjallen merged 1 commit intoMay 31, 2023
Merged
Conversation
josephsnyder
reviewed
May 4, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Things look good, @williamjallen. After grepping for some of the removed functions, I found that there is a reference to setTopicCollection in app/cdash/docs/NOTIFICATIONS.md. Is this some documentation that needs to be removed or does it need to be replaced?
Collaborator
Author
|
I'm honestly a little confused about those docs. In reality, they probably need a complete overhaul, but I'll update them to remove the reference to |
williamjallen
force-pushed
the
subscription-dead-code
branch
from
9c95a3c to
34651ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up a bit of dead code in
Subscription.phpand adds annotations to a few other files so IDEs and static analysis tools don't mark other functions as unused.