Fix broken buildnote.php#1395
Merged
Merged
Conversation
williamjallen
force-pushed
the
fix-buildnote
branch
from
fb59a2e to
5001069
Compare
williamjallen
force-pushed
the
fix-buildnote
branch
from
5001069 to
8fda011
Compare
josephsnyder
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AJAX endpoint which allows access to build note data is currently completely broken. The primary way this page is accessed is the icon on the administrative dashboard boxed in red below:
In addition to fixing the broken functionality, access controls which only allow administrators to access this endpoint were implemented. It was not clear what the intended access level was, but the only (legitimate) way to access this page is through the administrator UI.