Fix global asset routes#1413
Merged
Merged
Conversation
williamjallen
force-pushed
the
include-routes
branch
from
948d8a1 to
1385552
Compare
zackgalbreath
force-pushed
the
include-routes
branch
from
1385552 to
8cdd8a0
Compare
williamjallen
force-pushed
the
include-routes
branch
2 times, most recently
from
2e3a817 to
933a53b
Compare
zackgalbreath
force-pushed
the
include-routes
branch
from
933a53b to
b12d35b
Compare
zackgalbreath
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1351 failed to consider relative URLs properly and it is currently possible for assets to be missing on some pages if the route has multiple components. This PR fixes that by using Laravel's
asset()function for each of the assets.