Turn on PHPStan "bleeding edge" #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
phpstan-misc-config-settings
branch
from
46a302d to
dd1d3b6
Compare
williamjallen
force-pushed
the
phpstan-misc-config-settings
branch
from
dd1d3b6 to
55dddc8
Compare
williamjallen
force-pushed
the
phpstan-misc-config-settings
branch
from
55dddc8 to
f3a9f4e
Compare
josephsnyder
approved these changes
Aug 16, 2023
Member
|
@williamjallen, looks great but does need a rebase. |
williamjallen
force-pushed
the
phpstan-misc-config-settings
branch
from
f3a9f4e to
dfe9986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan offers a set of "bleeding edge" rules which are the stable rules which will be added in the next major release. We already use many of these rules through our usage of various optional packages, but there's no reason to not turn on additional static analysis rules. The only major difference between bleeding edge and our current setup is that bleeding edge mandates usage of the strict equality (
===and!==) operators. We already use the optional exception-checking rules which are included in bleeding edge.In addition to adding the bleeding edge rules, I have also enabled two more optional rules which are not included in any of our optional packages.