Fix buildSummary page notes API call#1430
Merged
Merged
Conversation
Add a leading slash to the API URL string to avoid keeping the "/build/" part of the URL from being added to the API call. If it was included, the Laravel routing wouldn't recognize it as an API call and return a 404. Add an icon to the notes "link". Fixes: Kitware#1429
williamjallen
approved these changes
May 15, 2023
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Changes look good to me. If @zackgalbreath has time, it might be good to double-check that the route still works on CDash instances running from a sub path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a leading slash to the API URL string to avoid keeping the "/build/" part of the URL from being added to the API call. If it was included, the Laravel routing wouldn't recognize it as an API call and return a 404.
Add an icon to show that the content is clickable, like other examples later on in the page
Fixes: #1429