Migrate plaintext file endpoints to Laravel controllers#1444
Merged
Conversation
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
One small question, otherwise I think things look good.
williamjallen
force-pushed
the
file-endpoints
branch
from
abc6b38 to
858c31c
Compare
josephsnyder
requested changes
May 30, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
DROP_SITE looks great but you went a little too far with the DROP_LOCATION
williamjallen
force-pushed
the
file-endpoints
branch
from
858c31c to
f2bdd50
Compare
Collaborator
Author
|
After discussion with @josephsnyder, I will make a separate PR to modify the contents of the |
josephsnyder
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have two files which return plaintext file data which were overlooked in #1351. This PR moves the logic for those two files into Laravel controllers for consistency with the rest of the codebase. This PR is part of a collection of forthcoming PRs which will move all routes to Laravel's routing system and do away with the need for
CDash.php.