Authorize request before returning images#1445
Merged
Merged
Conversation
williamjallen
force-pushed
the
image-protection
branch
from
1e6fd26 to
7b414e2
Compare
Member
|
@williamjallen, I'll move on to this next if you want to give it a quick rebase to remove conflicts |
williamjallen
force-pushed
the
image-protection
branch
from
7b414e2 to
34d5e03
Compare
josephsnyder
approved these changes
May 31, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Another merge conflict to go but otherwise looks great. Nice job!
williamjallen
force-pushed
the
image-protection
branch
from
34d5e03 to
486e45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1443. This PR also enables a test which was previously not included in our CI for some unknown reason.
This PR depends upon the changes in #1419, and should be merged after #1419.