Use middleware to check administrator status#1447
Merged
Merged
Conversation
josephsnyder
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently verify that the current user is an administrator before proceeding in multiple places throughout the codebase. This leads to the potential for authorization to go awry in some cases since each location performs the authorization differently.
This PR moves all of the administrator-checking logic to a dedicated middleware class. The downside of this change is that the administrator-checking code is separated from the "business" logic for admin-only pages. This means that. it is easy to accidentally introduce security vulnerabilities if our routing configuration gets messed up. To counter this possibility, I have added a test which verifies that each of the routes can only be accessed by administrators.
Once this PR is merged, I plan to go through each of the auth routes and remove unnecessary authentication-checking code.