Refactor Site and SiteInformation models#1468
Merged
Merged
Conversation
williamjallen
force-pushed
the
site-refactor
branch
4 times, most recently
from
32bf1e5 to
f56bc48
Compare
williamjallen
force-pushed
the
site-refactor
branch
2 times, most recently
from
81daef4 to
b4313b6
Compare
williamjallen
force-pushed
the
site-refactor
branch
from
b4313b6 to
7b1263c
Compare
josephsnyder
approved these changes
Jun 8, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Tests pass and the pages behave as expected in my manual perusing. Another great update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves as a rough indicator of the amount of work required to convert a legacy model to one based upon Laravel's Eloquent library. I plan to gradually migrate all of the smaller models to Eloquent through PRs such as this one, in the hope that doing so will make migrating the largest models easier at a future point in time.