Simplify project access control logic#1471
Merged
Merged
Conversation
williamjallen
force-pushed
the
common-project-logic
branch
from
5c322ec to
3cc6076
Compare
williamjallen
force-pushed
the
common-project-logic
branch
2 times, most recently
from
384e47a to
e9a1ac7
Compare
williamjallen
force-pushed
the
common-project-logic
branch
2 times, most recently
from
83badd2 to
f927b01
Compare
williamjallen
force-pushed
the
common-project-logic
branch
from
f927b01 to
8de1184
Compare
zackgalbreath
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1449 refactored a significant amount of project access control code, but a couple controllers were missed.
MapController,SubProjectController, andSubscribeProjectControllernow extendProjectControllerand are able to take advantage of a common access control check.