Add view() function to controllers
#1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
common-view-function
branch
from
a642695 to
5c36e78
Compare
williamjallen
force-pushed
the
common-view-function
branch
from
5c36e78 to
5ddbf42
Compare
williamjallen
force-pushed
the
common-view-function
branch
from
5ddbf42 to
210874b
Compare
williamjallen
force-pushed
the
common-view-function
branch
from
210874b to
84327e0
Compare
Collaborator
Author
|
A bunch of |
williamjallen
force-pushed
the
common-view-function
branch
from
84327e0 to
5267504
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
This PR removes a view composer which was rendered obsolete by #1351. In the future, it might be reasonable to consider adding a view composer which adds global information to the `cdash` view. That said, much of the work of a view composer is already done by simply embedding required information in our controller inheritance hierarchy, particularly by the method utilized in #1483.
josephsnyder
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a handful of things which get added to almost every view. By adding a custom
view()function in this PR, we can share more code and reduce the number of locations which have to get updated if the need for more "common" data arises.I skipped over a few controllers which need more extensive work when making these changes, and will fix those in a separate PR.