Fix project roles user search feature#1490
Merged
williamjallen merged 1 commit intoJun 16, 2023
Merged
Conversation
williamjallen
force-pushed
the
fix-project-roles-search
branch
2 times, most recently
from
cb27efa to
5c8bb1a
Compare
williamjallen
force-pushed
the
fix-project-roles-search
branch
from
5c8bb1a to
4bd3a20
Compare
josephsnyder
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the search feature on
manageProjectRoles.php. The search functionality was broken for the same fundamental reason which caused the bug fixed in #1486.As part of my bugfix, I have performed a small refactor of the
finduserproject.phpendpoint, including a security fix and general code cleanup.