Replace json_error_response() with abort()#1502
Merged
williamjallen merged 1 commit intoJun 21, 2023
Merged
Conversation
williamjallen
force-pushed
the
json_error_response-cleanup
branch
from
7f46f2c to
8a279aa
Compare
josephsnyder
approved these changes
Jun 21, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
builddetails test still fails to report correctly but I know there is more work to be done. All other aspects look in good shape!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1479 introduced a centralized error-handling system which returns a JSON error message for API routes and an HTML error page for pages with content which is meant to be consumed by humans. The recommended way to trigger the new error handling system is through Laravel's
abort()function which throws and then catches an exception, rather than using the currentjson_error_response()function which simply returns a JSON response and then exits. Exiting is problematic for our simpletest-based tests, because they won't catch the fact that the program exited prematurely with an error without running the remainder of the test suite.This PR replaces most of the existing usages of
json_error_response()with an equivalentabort(). The remaining usages ofjson_error_response()are more difficult to resolve and will be fixed in future PRs once I refactor the underlying infrastructure.