Move getviewcoverage.php AJAX route logic to Laravel controller#1504
Merged
Conversation
josephsnyder
approved these changes
Jun 22, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Reporting of coverage and display of (unfiltered) files seems unchanged. Great work!
williamjallen
force-pushed
the
ajax-view-coverage
branch
from
9ac0264 to
73dba66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to moving the logic for the
/ajax/getviewcoverage.phpendpoint to a Laravel controller, I have performed a modest refactor of the underlying code. In doing so, several small security vulnerabilities were patched and the code was modernized significantly. I also extended the refactor to the view coverage page itself, with a general cleanup of redundant and outdated code.