Fix email sent for errors in Update.xml#1508
Merged
Merged
Conversation
williamjallen
force-pushed
the
update_emails_error
branch
2 times, most recently
from
bc12de6 to
a33330b
Compare
williamjallen
commented
Jun 20, 2023
Comment on lines
+52
to
+54
| if ($collection === null) { | ||
| continue; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is the fix for the primary issue.
williamjallen
force-pushed
the
update_emails_error
branch
from
a33330b to
34c383d
Compare
CDash currently throws an HTTP 500 response when attempting to send an email about errors in a submitted Update.xml file.
williamjallen
force-pushed
the
update_emails_error
branch
from
34c383d to
32668df
Compare
josephsnyder
approved these changes
Jun 21, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
No issues consuming Nightly and Continuous submissions from my test repo now. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDash currently throws an HTTP 500 response when attempting to send an email
about errors in a submitted Update.xml file.
This PR fixes the 500 error and cleans up a variety of other small issues in the notification code. In the future, it would be good to give the notification code a more thorough cleanup, since the current code is difficult to debug due to the lack of correct type annotations, complex inheritance hierarchy, and large amounts of dead code.
Fixes #1498