Refactor buildProperties.php API endpoint#1524
Merged
williamjallen merged 2 commits intoJun 29, 2023
Merged
Conversation
williamjallen
force-pushed
the
api-buildProperties-refactor
branch
from
b74180f to
25b9695
Compare
josephsnyder
approved these changes
Jun 29, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
The above test failure seems to be a network error affecting multiple sets of tests around the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an ongoing effort to migrate all of our routes to Laravel's routing/controller system.
In addition to moving the core logic of the
buildProperties.phpAPI endpoint to a newBuildPropertiesController, I performed a light refactor and fixed an issue which allowed unauthorized users to view build output. Future work should be done to further clean up the code.