Skip to content

Convert build update page from AngularJS to Vue#1561

Merged
williamjallen merged 1 commit into
Kitware:masterfrom
williamjallen:build-update-vue-conversion
Jul 14, 2023
Merged

Convert build update page from AngularJS to Vue#1561
williamjallen merged 1 commit into
Kitware:masterfrom
williamjallen:build-update-vue-conversion

Conversation

@williamjallen
Copy link
Copy Markdown
Collaborator

This PR is part of our ongoing effort to migrate from AngularJS to Vue. There should be no functionality differences between the old and new versions of the page, beyond a new /build/<id>/update route.

@williamjallen williamjallen force-pushed the build-update-vue-conversion branch from fa26a80 to beedb84 Compare July 11, 2023 18:08
@williamjallen williamjallen marked this pull request as draft July 11, 2023 19:36
@williamjallen williamjallen force-pushed the build-update-vue-conversion branch 3 times, most recently from 55e3fd5 to bc06c80 Compare July 12, 2023 14:28
@williamjallen williamjallen marked this pull request as ready for review July 12, 2023 14:33
@williamjallen williamjallen force-pushed the build-update-vue-conversion branch from bc06c80 to 1d9203e Compare July 13, 2023 19:08
Copy link
Copy Markdown
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New route looks good, can't see any changes on the page.

@josephsnyder josephsnyder added this pull request to the merge queue Jul 14, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 14, 2023
@williamjallen williamjallen added this pull request to the merge queue Jul 14, 2023
Merged via the queue into Kitware:master with commit af1dd5c Jul 14, 2023
@williamjallen williamjallen deleted the build-update-vue-conversion branch July 14, 2023 15:47
github-merge-queue Bot pushed a commit that referenced this pull request Oct 17, 2023
Fixes #1748

This resolves a bug that was introduced in
#1561, and also adds a missing
check for the `CURRENT` navigation button.

Co-authored-by: Shelly Belsky <sbelsky@salaxala.khq.kitware.com>
zackgalbreath pushed a commit that referenced this pull request Nov 6, 2023
Fixes #1748

This resolves a bug that was introduced in
#1561, and also adds a missing
check for the `CURRENT` navigation button.

Co-authored-by: Shelly Belsky <sbelsky@salaxala.khq.kitware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants