Skip to content

Fix error when no files selected on manageCoverage.php#1598

Merged
williamjallen merged 3 commits into
Kitware:masterfrom
williamjallen:manage-coverage-no-files-selected
Aug 7, 2023
Merged

Fix error when no files selected on manageCoverage.php#1598
williamjallen merged 3 commits into
Kitware:masterfrom
williamjallen:manage-coverage-no-files-selected

Conversation

@williamjallen
Copy link
Copy Markdown
Collaborator

Fixes #1596.

@josephsnyder
Copy link
Copy Markdown
Member

On testing further, I found another 500 when attempting to sending emails:
image

I guess public function GetUsersFromProject(): array|false should return [] in the no user case?

@williamjallen
Copy link
Copy Markdown
Collaborator Author

@josephsnyder Is this bug fixed by #1619?

@josephsnyder
Copy link
Copy Markdown
Member

Is this bug fixed by #1619?

Yes, I decided it wasn't quite related to the work here and took on the fix myself. This one is good to go then!

@josephsnyder josephsnyder enabled auto-merge August 7, 2023 13:49
@josephsnyder josephsnyder disabled auto-merge August 7, 2023 13:49
@josephsnyder josephsnyder enabled auto-merge August 7, 2023 13:49
@josephsnyder josephsnyder disabled auto-merge August 7, 2023 13:49
@williamjallen williamjallen enabled auto-merge August 7, 2023 19:41
@williamjallen williamjallen added this pull request to the merge queue Aug 7, 2023
Merged via the queue into Kitware:master with commit 9a51cee Aug 7, 2023
@williamjallen williamjallen deleted the manage-coverage-no-files-selected branch August 7, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

500 error attempting to query empty list on manageCoverage.php

2 participants