Delete unnecessary includes#1621
Merged
Merged
Conversation
`require_once` generates an error, while `include_once` generates a warning and then continues running.
josephsnyder
approved these changes
Aug 8, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
#1621 reduced the number of repetitive `require_once` commands, but made the faulty assumption that the global functions being included were not necessary in any of the middleware. A more appropriate spot for these includes is Laravel's `AppServiceProvider`, which runs before the middleware does, and is generally the place to change global settings. Fixes #1630.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small handful of common files are included in many places where the include statement is not necessary. By moving the includes to core code paths, we can remove all of the repetitive includes.