Migrate removeBuilds.php backend from XSL to Blade
#1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
requested changes
Aug 14, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Most things look good but some fixes needed. A small display issue which will be easy to fix, but also a 500 when attempting to remove the builds from 3 days of history
williamjallen
force-pushed
the
removeBuilds-xsl-refactor
branch
from
db5e8b7 to
05acd7f
Compare
williamjallen
force-pushed
the
removeBuilds-xsl-refactor
branch
from
05acd7f to
6a05ffe
Compare
josephsnyder
approved these changes
Aug 15, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Great! Works on the MySQL environment that I have now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of our ongoing effort to migrate away from XSL completely.