Refactor viewNotes.php API endpoint
#1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
API looks good. Just one more update needed to mark the new controller class as final, if its appropriate
williamjallen
force-pushed
the
viewNotes-api-refactor
branch
from
1d3506f to
edd7046
Compare
williamjallen
force-pushed
the
viewNotes-api-refactor
branch
from
edd7046 to
786ffbe
Compare
josephsnyder
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues our ongoing migration of the API to Laravel's routing/controller system.