Convert viewDynamicAnalysis.php frontend to Vue
#1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
viewDynamicAnalysis-refactor
branch
from
4af820c to
2f90c81
Compare
Member
|
@williamjallen, the page loads and looks great. I have one nitpicky question:
The green, orange, or red backgrounds loose the |
Collaborator
Author
|
@josephsnyder Good catch! I believe that the issue is a difference between the |
williamjallen
force-pushed
the
viewDynamicAnalysis-refactor
branch
from
2f90c81 to
818f256
Compare
Member
|
Great! That looks much better. The only thing that I just noticed was that we lost the name of the project from the title of the page:
|
williamjallen
force-pushed
the
viewDynamicAnalysis-refactor
branch
from
818f256 to
0841762
Compare
josephsnyder
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of our ongoing effort to move away from AngularJS as our client-side rendering engine. I plan to write tests for this page in Cypress, once I get that set up.