Deprecate legacy Config class
#1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
reviewed
Sep 8, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
One quick question about a function not marked as deprecated, but otherwise looks great!
josephsnyder
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything the legacy
Configclass does can be done by an equivalent Laravel helper function. As such, there is no longer a need for theConfigclass, and it has been marked as deprecated. I tried to simply replace each of the deprecated functions with laravel equivalents, but a few quirks with our testing suite make it a nontrivial task.I created a new function for getting the current CDash version in the base controller class. This is now the preferred method to use for getting the version. I intend to make a separate PR once this is merged to simplify our versioning logic.