Convert backend of Build model to Eloquent#1700
Merged
williamjallen merged 1 commit intoKitware:masterfrom Sep 8, 2023
Merged
Conversation
josephsnyder
approved these changes
Sep 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
williamjallen
force-pushed
the
build-eloquent-model
branch
from
811641a to
074c003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows #1674 and converts the parts of the
Buildmodel which interact directly with thebuildtable to Eloquent wherever feasible. I intend to slowly switch more parts of the codebase to the Eloquent-based model, but that work will happen in separate PRs. By simply having an EloquentBuildmodel present, we can do significantly more in other Eloquent models.