Increase token length from 128 bits to 512 bits#1723
Merged
williamjallen merged 1 commit intoKitware:masterfrom Sep 28, 2023
Merged
Increase token length from 128 bits to 512 bits#1723williamjallen merged 1 commit intoKitware:masterfrom
williamjallen merged 1 commit intoKitware:masterfrom
Conversation
josephsnyder
approved these changes
Sep 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zackgalbreath
pushed a commit
that referenced
this pull request
Nov 6, 2023
Authentication tokens currently only contain 128 bits of entropy. This PR increases the entropy to 512 bits, which is the maximum value we can use without changing the hashing algorithm. If we limit the available character set to the 62 upper- and lower-case alphanumeric characters, 86 characters are necessary to exceed 512 bits of entropy, assuming my calculations are correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authentication tokens currently only contain 128 bits of entropy. This PR increases the entropy to 512 bits, which is the maximum value we can use without changing the hashing algorithm. If we limit the available character set to the 62 upper- and lower-case alphanumeric characters, 86 characters are necessary to exceed 512 bits of entropy, assuming my calculations are correct.