Sanitize column names before timeline.php query
#1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Oct 2, 2023
zackgalbreath
pushed a commit
that referenced
this pull request
Nov 6, 2023
`timeline.php` currently accepts arbitrary strings as column names, which opens us up to SQL injection attacks. This PR sanitizes the column names such that only the intended column names can be used. I also added a basic test to ensure that this check continues to work in the future. As part of adding the test, I was forced to migrate the API endpoint to the new controller system without fully replacing the legacy controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeline.phpcurrently accepts arbitrary strings as column names, which opens us up to SQL injection attacks. This PR sanitizes the column names such that only the intended column names can be used. I also added a basic test to ensure that this check continues to work in the future. As part of adding the test, I was forced to migrate the API endpoint to the new controller system without fully replacing the legacy controller.