Eliminate pdo_real_escape_numeric() function#1728
Merged
williamjallen merged 1 commit intoKitware:masterfrom Oct 2, 2023
Merged
Eliminate pdo_real_escape_numeric() function#1728williamjallen merged 1 commit intoKitware:masterfrom
pdo_real_escape_numeric() function#1728williamjallen merged 1 commit intoKitware:masterfrom
Conversation
josephsnyder
approved these changes
Oct 2, 2023
Member
|
@williamjallen, looks good and we can merge after a rebase! |
williamjallen
force-pushed
the
unnecessary-value-quoting
branch
from
cc4ba85 to
63d8f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integers are always safe to insert in SQL queries. Thus, we can eliminate the
pdo_real_escape_numeric()function and replace all of the existing usages with integer casts. In the vast majority of cases, this function was no longer being used to sanitize values for SQL queries anyway.