Use Laravel query builder for DELETE statements when possible#1729
Merged
williamjallen merged 1 commit intoKitware:masterfrom Oct 6, 2023
Merged
Conversation
josephsnyder
approved these changes
Oct 4, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
I haven't found an issue with usage yet and the code looks good to me. Once rebased, it'll be ready to merge!
williamjallen
force-pushed
the
deprecated-delete-queries
branch
from
a6e1084 to
7da9346
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have several pre-laravel methods which can execute DELETE queries, but it is preferable to use Laravel's database functions instead. One advantage is that all queries executed by laravel are visible in Laravel's query log, which helps debug performance issues. DELETE statements are an easy starting place because the return value is rarely used.