Simplify copied code in coverage file pivot model#1754
Merged
josephsnyder merged 1 commit intoKitware:masterfrom Nov 14, 2023
Merged
Simplify copied code in coverage file pivot model#1754josephsnyder merged 1 commit intoKitware:masterfrom
josephsnyder merged 1 commit intoKitware:masterfrom
Conversation
sbelsk
reviewed
Oct 20, 2023
williamjallen
force-pushed
the
coverage-users-duplicate-code
branch
from
7fa546e to
b91a92e
Compare
josephsnyder
approved these changes
Nov 14, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Changes here LGTM, No issues when testing
sbelsk
pushed a commit
to sbelsk/CDash
that referenced
this pull request
Nov 20, 2023
The `CoverageFile2User` model contained two functions which differed by only a single parameter on one function call. This rather trivial PR simply eliminates one of the functions, and adds an extra argument to the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CoverageFile2Usermodel contained two functions which differed by only a single parameter on one function call. This rather trivial PR simply eliminates one of the functions, and adds an extra argument to the other.