Set up Project<->Build Eloquent relationship#1756
Merged
williamjallen merged 1 commit intoKitware:masterfrom Oct 23, 2023
Merged
Set up Project<->Build Eloquent relationship#1756williamjallen merged 1 commit intoKitware:masterfrom
williamjallen merged 1 commit intoKitware:masterfrom
Conversation
josephsnyder
approved these changes
Oct 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
williamjallen
force-pushed
the
project-build-relationship
branch
from
1116f87 to
ec5d334
Compare
williamjallen
force-pushed
the
project-build-relationship
branch
from
ec5d334 to
fc33d43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Eloquent relationships between the
Projectmodel and theBuildmodel.I used the new relationships to replace a few existing SQL queries in the legacy project model as examples, but by no means did I attempt to locate and refactor every possible place where the relationships can be used. I expect to gradually use them more through my work in other PRs.