Fix Angular routing behavior after login #1758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
requested changes
Oct 27, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
@williamjallen, I've got the redirect to test but it seems to be dropping the URL query parameters and I'm not sure that's what is intended:
Steps to reproduce:
I have a private project called test, I can see the testOverview page when signed in at /testOverview.php?project=test
If I sign out and attempt to visit that URL, it shows me the login screen without changing the URL in the address bar:
and after logging in takes me back to testOverview.php but without any query parameters and I get an error message:
williamjallen
force-pushed
the
angular-login-redirect
branch
from
7e8bbdb to
4c57616
Compare
Collaborator
Author
|
Good catch! The same issue also occurred on non-angular pages, so I fixed it in both locations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages rendered by AngularJS which require authentication currently redirect to the index page after login. This is inconsistent with the behavior elsewhere, where the user is redirected back to the page they attempted to access prior to being redirected to the login page.
This PR is a temporary patch to make the login redirect behavior more consistent. The ultimate goal is to remove AngularJS entirely.