Refactor legacy User model#1802
Merged
josephsnyder merged 13 commits intoKitware:masterfrom Nov 17, 2023
Merged
Conversation
As of PHP 8, password_hash() only ever returns a string. No need to have a wrapper function checking for a return value of false.
josephsnyder
approved these changes
Nov 17, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
All the user interactions I can test manually look unchanged from a user's POV. I think this is a great change.
sbelsk
pushed a commit
to sbelsk/CDash
that referenced
this pull request
Nov 20, 2023
We currently have two user models: a legacy model, and an Eloquent model. The reflection approach used to access legacy model members through the Eloquent model is not conducive to static analysis, and is a pain to work with. This PR moves a significant portion of the legacy model logic to the Eloquent model. Additionally, I have improved the User<->Password model relationship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have two user models: a legacy model, and an Eloquent model. The reflection approach used to access legacy model members through the Eloquent model is not conducive to static analysis, and is a pain to work with. This PR moves a significant portion of the legacy model logic to the Eloquent model. Additionally, I have improved the User<->Password model relationship.