Rename "Services" to "Utilities"#1856
Merged
josephsnyder merged 4 commits intoKitware:masterfrom Dec 4, 2023
Merged
Conversation
josephsnyder
approved these changes
Dec 4, 2023
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Looks good to me. I don't see an issue in the testing or in some brief manual exploration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Laravel, a "service" is a specific term used to describe service providers. CDash stores those at the default
app/Providerspath. Having an additionalapp/Servicesdirectory is confusing, because the contents therein are not services. The current contents ofapp/Servicesare simply helper classes, mostly classes with static member functions for performing various utility features. As such, I have renamed the directory toapp/Utils.I eventually plan to move some of our legacy global functions into container classes in this directory. Some of the global functions pollute our global namespace, and interfere with static analysis