Make sure Laravel storage directories exist#1857
Merged
Merged
Conversation
When using a separate volume for CDash's storage directory, we need to ensure the existence of certain directories that Laravel expects. We solve this problem by creating a new artisan command and running it from our Docker entrypoint.
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Seems reasonable overall. A few optional points for you to consider:
- Should this be added to our new
cdash_install(#1818) script? - Should the empty
storage/*directories be removed from git? Doing so would allow you to fully abstract away all of the raw filesystem paths, and rely purely upon Laravel's storage facade.
williamjallen
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a separate volume for CDash's storage directory, we need to ensure the existence of certain directories that Laravel expects.
We solve this problem by creating a new artisan command and running it from our Docker entrypoint.