Delete duplicate version.php configuration file#1873
Merged
josephsnyder merged 1 commit intoKitware:masterfrom Dec 11, 2023
Merged
Delete duplicate version.php configuration file#1873josephsnyder merged 1 commit intoKitware:masterfrom
version.php configuration file#1873josephsnyder merged 1 commit intoKitware:masterfrom
Conversation
williamjallen
force-pushed
the
unused-version-php
branch
from
8b2daae to
db7d2f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The laravel configuration file in
.../config/cdash.phpcontains version information which duplicates the information in the legacyversion.php. This PR eliminates the legacy configuration file, and migrates all of the version-checking code to Laravel's configuration system.