Finalize removal of old OAuth capabilites#1885
Merged
williamjallen merged 1 commit intoKitware:masterfrom Jan 12, 2024
Merged
Conversation
josephsnyder
force-pushed
the
remove_oauth_requirements
branch
from
e9e013b to
8f89415
Compare
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
I believe there are a few more things you can remove:
app/cdash/app/Controller/Auth/Session.php(and the associatedapp/cdash/config/di.php)$OAUTH2_PROVIDERSinapp/cdash/config/config.phpand associated files
josephsnyder
force-pushed
the
remove_oauth_requirements
branch
2 times, most recently
from
723a7bc to
7bac39c
Compare
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
I believe you can now delete everything except system_exit() from app/cdash/include/CDash/System.php. I'll create a follow-up PR to finish the remaining system_exit()/System class stuff.
josephsnyder
force-pushed
the
remove_oauth_requirements
branch
from
7bac39c to
1643777
Compare
Remove now unnecessary interfaces and tests for code that is not longer in existance. Add information to the documentation about the automatic registering. SAML should remain unchanged.
josephsnyder
force-pushed
the
remove_oauth_requirements
branch
from
1643777 to
f9005a5
Compare
williamjallen
approved these changes
Jan 12, 2024
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Looks good. I believe there are a few spots which related code can now be cleaned up, but I'll take care of those at a future point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove now unnecessary interfaces and tests for code that is not longer in existance.
Add information to the documentation about the automatic registering. SAML should remain unchanged.