Skip to content

Refactor build.php API endpoint#1892

Merged
josephsnyder merged 1 commit intoKitware:masterfrom
williamjallen:build-api-endpoint-refactor
Dec 21, 2023
Merged

Refactor build.php API endpoint#1892
josephsnyder merged 1 commit intoKitware:masterfrom
williamjallen:build-api-endpoint-refactor

Conversation

@williamjallen
Copy link
Collaborator

This PR continues our ongoing effort to modernize the codebase by migrating the legacy API files to Laravel controllers.

@josephsnyder
Copy link
Member

@williamjallen, I'm having trouble getting anything back from the API, the new ones return just [ ] but the old version seems to return blank on my test instance. Are you able to get data in your test system?

@williamjallen williamjallen force-pushed the build-api-endpoint-refactor branch from 3e1d9ec to 014be85 Compare December 21, 2023 17:23
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the knowledge that the get call here returns nothing back to the screen as it does in the master branch, it LGTM.

ETA: Blank return when adding no parameters to the api call (build.php?buildid=1). Data is properly returned for further queries (build.php?buildid=1&getproblems=1)

@williamjallen
Copy link
Collaborator Author

As discussed face-to-face, this endpoint is somewhat broken. My refactor only attempts to match the current behavior rather than fixing any of the issues. This endpoint is one of the first I plan to deprecate once #1772 is merged.

@josephsnyder josephsnyder added this pull request to the merge queue Dec 21, 2023
Merged via the queue into Kitware:master with commit a7df7d2 Dec 21, 2023
@williamjallen williamjallen deleted the build-api-endpoint-refactor branch December 21, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments