-
Notifications
You must be signed in to change notification settings - Fork 80
Refactor Docker startup scripts #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Docker startup scripts #1893
Conversation
bstrdsmkr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williamjallen we recently deployed CDash in k8s and this would have made our lives easier, so thanks for the work!
I wanted to share a couple of other comments from our experience that could make things even easier
|
@williamjallen, I'm having some trouble wrapping my mind around stopping the admin user creation. If a development environment runs the install step for us, we don't see the install page to set an account as an admin. One can get all the way to the login, and register a normal user, but then cannot create any projects. Can we update the docker documentation to point out the |
|
Good idea. I'll add a note to the docs. The install page is of limited use for bare-metal systems, and is almost entirely useless for container-based systems. Using environment variables is by far the preferred way to go about setting configuration settings. I'll add a note to the docs in case anyone happens to be interested in manually creating a user for whatever reason. |
josephsnyder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase for a conflict but otherwise LGTM!
2bc7024 to
8da3737
Compare
It is traditional to name your dockerfile "Dockerfile".
8da3737 to
384929b
Compare
Our Docker installation process was originally designed for testing and development purposes. With Kubernetes and other container-based deployment mechanisms becoming widespread, our Docker setup scripts are in need of a refactor to make them deployment-quality.
Amongst a slew of general refactoring work, I made the following notable changes:
Dockerfilein accordance with traditional Docker naming conventions.APP_KEYis no longer generated by default. Users must specify it manually, and the container with fail to start with a message showing a random key if theAPP_KEYenvironment variable is not set. Automatically generating keys as was done before is a bad idea, because the key (and thus, any data encrypted with it), will be lost if the container is restarted for any reason.php artisan config:migrate.I plan to make another PR to overhaul the Dockerfile and switch to php-fpm sometime soon.