Skip to content

Conversation

@bstrdsmkr
Copy link
Contributor

When using remote workers, the GuzzleHttp client isn't found in the namespace, add a \ to use the global namespace

Files waiting on remote workers are copied into the inprogress directory, but the remote api looks for them in the inbox directory

@williamjallen
Copy link
Collaborator

These changes seem reasonable to me, although it looks like you need to remove some errors from the PHPStan baseline. You can do that with vendor/bin/phpstan analyse --memory-limit=8G --generate-baseline. @zackgalbreath is more familiar with this feature than I am, and should do a final review before this can be merged.

@zackgalbreath
Copy link
Contributor

I confirmed locally that this functionality was broken, and that this PR fixes it.

Thanks for the contribution, @bstrdsmkr !

@zackgalbreath zackgalbreath self-requested a review January 12, 2024 16:01
@zackgalbreath zackgalbreath added this pull request to the merge queue Jan 12, 2024
Merged via the queue into Kitware:master with commit 23adc57 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants