Skip to content

Convert banner test to Cypress#1898

Merged
williamjallen merged 1 commit intoKitware:masterfrom
williamjallen:banner-cypress-test
Dec 29, 2023
Merged

Convert banner test to Cypress#1898
williamjallen merged 1 commit intoKitware:masterfrom
williamjallen:banner-cypress-test

Conversation

@williamjallen
Copy link
Collaborator

This PR is simply a one-to-one conversion of the banner management test from our legacy UI testing infrastructure to Cypress.

@sbelsk
Copy link
Collaborator

sbelsk commented Dec 19, 2023

Does Cypress automatically produce clear error messages when expected values/states don't match? If not, it might be nice to preserve a few of the error message descriptions of what the tests attempts to check (or at least preserve the comments in the test source).

@williamjallen
Copy link
Collaborator Author

If you run the tests locally, you can watch Cypress click around the page and see what's missing. There isn't a great way to provide error messages when assertions fail in Cypress.

In practice, most of the "helpful" messages we have in the CDash codebase aren't particularly useful when the tests fail, and being able to see the problem is a much better solution.

@williamjallen williamjallen added this pull request to the merge queue Dec 29, 2023
Merged via the queue into Kitware:master with commit 166a06b Dec 29, 2023
@williamjallen williamjallen deleted the banner-cypress-test branch December 29, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments