Convert banner test to Cypress#1898
Merged
williamjallen merged 1 commit intoKitware:masterfrom Dec 29, 2023
Merged
Conversation
Collaborator
|
Does Cypress automatically produce clear error messages when expected values/states don't match? If not, it might be nice to preserve a few of the error message descriptions of what the tests attempts to check (or at least preserve the comments in the test source). |
Collaborator
Author
|
If you run the tests locally, you can watch Cypress click around the page and see what's missing. There isn't a great way to provide error messages when assertions fail in Cypress. In practice, most of the "helpful" messages we have in the CDash codebase aren't particularly useful when the tests fail, and being able to see the problem is a much better solution. |
sbelsk
approved these changes
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is simply a one-to-one conversion of the banner management test from our legacy UI testing infrastructure to Cypress.