Convert the colorblind protractor test to cypress#1929
Merged
sbelsk merged 1 commit intoKitware:masterfrom Jan 3, 2024
Merged
Conversation
williamjallen
approved these changes
Jan 2, 2024
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Changes seem reasonable. The new test is likely to break if any changes are made to the underlying HTML, but it's certainly no worse than the original Protractor test. We can add a more thorough test later.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes covert the colorblind mode end-to-end test to Cypress, as part of our efforts at moving away from Protractor.