Fix links to and from site page #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
requested changes
Jan 5, 2024
Fix the controller to accept that the site page can be accessed without specifying a project. Ensure that the links back to the projects of a site have the leading `/` to not be relative to the `sites/` of the page.
Use the configuration setting 'app.url' to capture the proper way to reach the root of the webserver and properly create the link.
josephsnyder
force-pushed
the
fix_site_links
branch
from
56dc6c7 to
71eabc4
Compare
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Changes seem reasonable. I will approve after some brief stylistic changes.
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
williamjallen
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the controller to accept that the site page can be accessed without specifying a project.
Ensure that the links back to the projects of a site have the leading
/to not be relative to thesites/of the page.